Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change limit crypto list fetched to 5000 #331

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

hichri-louay
Copy link
Contributor

PR Description:

Hello team,

This PR addresses two key issues to improve our application's functionality and efficiency:

Issue 1 - Increased Crypto List Fetch Limit:

Currently, our application fetches cryptocurrency data from Coin Market Cap with a limit of 1200 assets. However, as our user base grows and the cryptocurrency market expands, we need to provide access to a wider range of assets. To address this, we have increased the limit for fetching crypto lists from 1200 to 5000. This expansion ensures that our users can access a more comprehensive list of cryptocurrencies.

Issue 2 - Optimized Network Retrieval with Batch Concept:

In the process of fetching data about networks associated with tokens, we have observed that there is a maximum limit of 1300 networks that can be retrieved at once. To overcome this limitation, we have implemented a batch concept in the getNetworkByToken function. This modification allows us to efficiently fetch network data while staying within the constraints imposed by external services.

Changes Made:

  • Increased the crypto list fetch limit from Coin Market Cap to 5000 assets, providing users with access to a broader range of cryptocurrencies.
  • Implemented a batch concept in the getNetworkByToken function to optimize network data retrieval, ensuring efficient handling of a large number of networks.

Notes for Reviewers:

Please review the changes introduced in this PR to ensure that the increased crypto list fetch limit and the batch concept in the getNetworkByToken function are correctly implemented. Verify that these changes enhance the user experience and improve the efficiency of our application.

Your attention and contributions are highly appreciated. Feel free to provide any feedback or suggestions you may have.

Best regards,
Louay HICHRI

@hichri-louay hichri-louay merged commit 23f34fc into develop Sep 13, 2023
3 checks passed
@hichri-louay hichri-louay deleted the add-limit-coinmarketcap-api branch September 13, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant