change limit crypto list fetched to 5000 #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Hello team,
This PR addresses two key issues to improve our application's functionality and efficiency:
Issue 1 - Increased Crypto List Fetch Limit:
Currently, our application fetches cryptocurrency data from Coin Market Cap with a limit of 1200 assets. However, as our user base grows and the cryptocurrency market expands, we need to provide access to a wider range of assets. To address this, we have increased the limit for fetching crypto lists from 1200 to 5000. This expansion ensures that our users can access a more comprehensive list of cryptocurrencies.
Issue 2 - Optimized Network Retrieval with Batch Concept:
In the process of fetching data about networks associated with tokens, we have observed that there is a maximum limit of 1300 networks that can be retrieved at once. To overcome this limitation, we have implemented a batch concept in the getNetworkByToken function. This modification allows us to efficiently fetch network data while staying within the constraints imposed by external services.
Changes Made:
Notes for Reviewers:
Please review the changes introduced in this PR to ensure that the increased crypto list fetch limit and the batch concept in the getNetworkByToken function are correctly implemented. Verify that these changes enhance the user experience and improve the efficiency of our application.
Your attention and contributions are highly appreciated. Feel free to provide any feedback or suggestions you may have.
Best regards,
Louay HICHRI