Remove Debug ifdefs around description

Saadnajmi · Sep 24, 2023 · 8a7159f · 8a7159f
1 parent 098af1c
commit 8a7159f
Show file tree

Hide file tree

Showing 14 changed files with 0 additions and 28 deletions.
diff --git a/packages/react-native/Libraries/Text/RawText/RCTRawTextShadowView.mm b/packages/react-native/Libraries/Text/RawText/RCTRawTextShadowView.mm
@@ -24,13 +24,11 @@ - (void)dirtyLayout
   [self.superview dirtyLayout];
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   NSString *superDescription = super.description;
   return [[superDescription substringToIndex:superDescription.length - 1]
       stringByAppendingFormat:@"; text: %@>", self.text];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/Base/RCTImageSource.m b/packages/react-native/React/Base/RCTImageSource.m
@@ -42,7 +42,6 @@ - (BOOL)isEqual:(RCTImageSource *)object
       (CGSizeEqualToSize(_size, object.size) || CGSizeEqualToSize(object.size, CGSizeZero));
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString stringWithFormat:@"<RCTImageSource: %p URL=%@, size=%@, scale=%0.f>",
@@ -51,7 +50,6 @@ - (NSString *)description
                                     NSStringFromCGSize(_size),
                                     _scale];
 }
-#endif // macOS]
 
 @end
 

diff --git a/packages/react-native/React/Base/RCTJSStackFrame.m b/packages/react-native/React/Base/RCTJSStackFrame.m
@@ -136,7 +136,6 @@ + (instancetype)stackFrameWithDictionary:(NSDictionary *)dict
   return stack;
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString stringWithFormat:@"<%@: %p method name: %@; file name: %@; line: %ld; column: %ld>",
@@ -147,6 +146,5 @@ - (NSString *)description
                                     (long)self.lineNumber,
                                     (long)self.column];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/Base/RCTJavaScriptLoader.mm b/packages/react-native/React/Base/RCTJavaScriptLoader.mm
@@ -49,7 +49,6 @@ @implementation RCTSource
 
 @implementation RCTLoadingProgress
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   NSMutableString *desc = [NSMutableString new];
@@ -65,7 +64,6 @@ - (NSString *)description
   [desc appendString:@"\u2026"];
   return desc;
 }
-#endif // macOS]
 
 @end
 

diff --git a/packages/react-native/React/Base/RCTKeyCommands.m b/packages/react-native/React/Base/RCTKeyCommands.m
@@ -75,7 +75,6 @@ - (BOOL)matchesInput:(NSString *)input flags:(UIKeyModifierFlags)flags
   return [_key isEqual:input] && (_flags == flags || flags == 0);
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString stringWithFormat:@"<%@:%p input=\"%@\" flags=%lld hasBlock=%@>",
@@ -85,7 +84,6 @@ - (NSString *)description
                                     (long long)_flags,
                                     _block ? @"YES" : @"NO"];
 }
-#endif // macOS]
 
 @end
 

diff --git a/packages/react-native/React/Base/RCTModuleData.mm b/packages/react-native/React/Base/RCTModuleData.mm
@@ -494,11 +494,9 @@ - (void)invalidate
   _methodQueue = nil;
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString stringWithFormat:@"<%@: %p; name=\"%@\">", [self class], self, self.name];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/Base/RCTModuleMethod.mm b/packages/react-native/React/Base/RCTModuleMethod.mm
@@ -602,7 +602,6 @@ - (NSString *)methodName
   return [NSString stringWithFormat:@"-[%@ %s]", _moduleClass, sel_getName(_selector)];
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString stringWithFormat:@"<%@: %p; exports %@ as %s(); type: %s>",
@@ -612,6 +611,5 @@ - (NSString *)description
                                     self.JSMethodName,
                                     RCTFunctionDescriptorFromType(self.functionType)];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/Base/RCTTouchEvent.m b/packages/react-native/React/Base/RCTTouchEvent.m
@@ -98,12 +98,10 @@ - (uint16_t)coalescingKey
   return _coalescingKey;
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString
       stringWithFormat:@"<%@: %p; name = %@; coalescing key = %hu>", [self class], self, _eventName, _coalescingKey];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/CxxModule/RCTCxxMethod.mm b/packages/react-native/React/CxxModule/RCTCxxMethod.mm
@@ -131,11 +131,9 @@ - (id)invokeWithBridge:(RCTBridge *)bridge module:(id)module arguments:(NSArray
   }
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString stringWithFormat:@"<%@: %p; name = %s>", [self class], self, self.JSMethodName];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/Modules/RCTLayoutAnimation.m b/packages/react-native/React/Modules/RCTLayoutAnimation.m
@@ -190,7 +190,6 @@ - (BOOL)isEqual:(RCTLayoutAnimation *)animation
       _animationType == animation.animationType;
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString
@@ -205,6 +204,5 @@ - (NSString *)description
           _initialVelocity,
           (long)_animationType];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/Modules/RCTLayoutAnimationGroup.m b/packages/react-native/React/Modules/RCTLayoutAnimationGroup.m
@@ -64,7 +64,6 @@ - (BOOL)isEqual:(RCTLayoutAnimationGroup *)layoutAnimation
        [_deletingLayoutAnimation isEqual:deletingLayoutAnimation]);
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return
@@ -76,6 +75,5 @@ - (NSString *)description
                     [_updatingLayoutAnimation description],
                     [_deletingLayoutAnimation description]];
 }
-#endif // macOS]
 
 @end
diff --git a/packages/react-native/React/Views/RCTShadowView.m b/packages/react-native/React/Views/RCTShadowView.m
@@ -393,7 +393,6 @@ - (NSNumber *)reactTagAtPoint:(CGPoint)point
   return self.reactTag;
 }
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   NSString *description = super.description;
@@ -404,7 +403,6 @@ - (NSString *)description
                               NSStringFromCGRect(self.layoutMetrics.frame)];
   return description;
 }
-#endif // macOS]
 
 - (void)addRecursiveDescriptionToString:(NSMutableString *)string atLevel:(NSUInteger)level
 {

diff --git a/packages/react-native/React/Views/RCTView.m b/packages/react-native/React/Views/RCTView.m
@@ -727,15 +727,13 @@ - (BOOL)accessibilityPerformShowMenu
 }
 #endif // macOS]
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [[super description] stringByAppendingFormat:@" reactTag: %@; frame = %@; layer = %@",
                                                       self.reactTag,
                                                       NSStringFromCGRect(self.frame),
                                                       self.layer];
 }
-#endif // macOS]
 
 #if TARGET_OS_OSX // [macOS
 - (void)setShadowColor:(NSColor *)shadowColor

diff --git a/packages/rn-tester/RCTTest/FBSnapshotTestCase/FBSnapshotTestController.m b/packages/rn-tester/RCTTest/FBSnapshotTestCase/FBSnapshotTestController.m
@@ -53,12 +53,10 @@ - (instancetype)initWithTestName:(NSString *)testName
 
 #pragma mark - Properties
 
-#if DEBUG // [macOS description is a debug-only feature
 - (NSString *)description
 {
   return [NSString stringWithFormat:@"%@ %@", [super description], _referenceImagesDirectory];
 }
-#endif // macOS]
 
 #pragma mark - Public API