Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new features and review #7

Merged
merged 8 commits into from
May 18, 2019
Merged

Add new features and review #7

merged 8 commits into from
May 18, 2019

Conversation

geaaru
Copy link
Contributor

@geaaru geaaru commented May 18, 2019

No description provided.

@geaaru geaaru requested a review from mudler May 18, 2019 13:22
mudler
mudler requested changes May 18, 2019
View reviewed changes
Copy link
Member

@mudler mudler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside that minor thing looks good to me, shouldn't prevent merge

sark-localcreaterepo Show resolved Hide resolved
@mudler mudler merged commit 1812f2b into master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geaaru @mudler