Addressing my own review on monodevec PR #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so type argument does not have to be <:Integer example: round(Float32, rand(1:5,5,5) .// rand(1:5,5,5))
|
Ah I see why you tightened the signature, that introduces ambiguities. Will fix and replace the second commit. |
was previously defined for AbstractSparseVector, and there was a typo that was giving a method redefinition warning because Sparse should have been Strided fix ambiguity
tkelman
force-pushed
the
tk/monodevec
branch
from
6af1a7a
to
f8892dc
Compare
|
fixed, commit replaced |
|
moved to JuliaLang#19798 |
Sacha0
pushed a commit
that referenced
this pull request
Apr 26, 2017
This changes nprocs (and therefore nworkers) report only workers in `W_CONNECTED` state. This is to avoid issue with `@everywhere` or other similar methods that broadcast messages to all workers. To simulate: - introduce an artificial delay at https://github.com/JuliaLang/julia/blob/2c4f6d74577a1b7606ed5e74e96158810f4f7af4/base/distributed/cluster.jl#L443 with `sleep(10)` - start a master with: ``` using ClusterManagers ElasticManager(;addr=IPv4("0.0.0.0"), port=9009, cookie="cookie", topology=:master_slave) while nworkers() < 4 sleep(1) end @Everywhere println(myid()) ``` - start 4 workers with: ``` using ClusterManagers ClusterManagers.elastic_worker("cookie", "127.0.0.1", 9009; stdout_to_master=false) ``` Without this change, this will often result in: ``` ERROR: LoadError: peer 3 is not connected to 1. Topology : master_slave check_worker_state(::Base.Distributed.Worker) at ./distributed/cluster.jl:115 send_msg_(::Base.Distributed.Worker, ::Base.Distributed.MsgHeader, ::Base.Distributed.CallMsg{:call_fetch}, ::Bool) at ./distributed/messages.jl:180 remotecall_fetch(::Function, ::Base.Distributed.Worker, ::Expr, ::Vararg{Expr,N} where N) at ./distributed/remotecall.jl:346 remotecall_fetch(::Function, ::Int64, ::Expr, ::Vararg{Expr,N} where N) at ./distributed/remotecall.jl:367 (::##1#3)() at ./distributed/macros.jl:84 ```
Sacha0
pushed a commit
that referenced
this pull request
May 5, 2018
Add config, unicode/ascii, scroll wrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hiya @Sacha0, figured it'd be easier to write the patch myself addressing my comments on JuliaLang#19791
recommend "rebase and merge" if you agree