Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes border radius from transparent input in UpdateableLatestForecast #63

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jonnyspicer
Copy link
Collaborator

Pull Request: Removes border radius from transparent input in UpdateableLatestForecast

Related Issue

Asana ref

Changes Made

  • Removes rounded-md from transparent input element in UpdateableLatestForecast component

Testing

Tested locally and in preview
Before/after:
Screenshot 2024-09-25 at 16 49 42
Screenshot 2024-09-25 at 16 49 51

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forecast-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 3:56pm

@jonnyspicer jonnyspicer self-assigned this Sep 25, 2024
@jonnyspicer
Copy link
Collaborator Author

I could maybe merge this without review - as far as I can tell I haven't missed this component being used elsewhere in the codebase, mostly just wanted you to check rounded-md isn't a Chesterton's Fence thing

Copy link
Contributor

@adam-binks adam-binks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge this kinda thing without review

@jonnyspicer jonnyspicer merged commit fab67f1 into main Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants