Update CI set-up #26
Merged
Update CI set-up #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBrowne
force-pushed
the
revise_ci_setup
branch
from
bb28157
to
4a32450
Compare
timlapluie
previously approved these changes
Mar 5, 2024
timlapluie
force-pushed
the
revise_ci_setup
branch
2 times, most recently
from
72d8872
to
28ebbaf
Compare
KevinBrowne
force-pushed
the
revise_ci_setup
branch
3 times, most recently
from
9e9ffb4
to
ea716c6
Compare
KevinBrowne
force-pushed
the
revise_ci_setup
branch
from
ea716c6
to
3b2445b
Compare
Change CI workflow trigger -------------------------- Change CI workflow to run on PRs. Prior to this, the trigger for a CI build was a push to the repo. This meant that PRs from forks did not trigger a CI run, so they could never meet the requirements of the branch protection rules. A repo maintainer must approve the workflow run for PRs from external forks, in order to prevent abuse. This is already configured. Restrict upload of code coverage report to Code Climate ------------------------------------------------------- Restrict the coverage report upload to builds triggered by: * pushes to master (these are mainly merges of PRs); * pushes of version number tags; and * PRs not raised from forks or by Dependabot PRs from forks or Dependabot do not have access to the secrets needed to upload the report to Code Climate, and there's no point tainting their CI builds with failures from the coverage upload. A few branch protection rules depended on the report being uploaded. These have been removed so that PRs from forks and Dependabot can actually pass CI. Push a tag to set the gem version and build the gem --------------------------------------------------- Pushing a tag of the format vX.Y.Z will trigger a CI test run and then build the gem and push it to Ruby Gems if the tests pass. The gemspec will automatically set the version number based on the tag. This is done in a new job in the CI workflow. This requires access to a secret but, as the workflow will have been triggered by a push, the workflow will have access to the secrets in this case.
KevinBrowne
force-pushed
the
revise_ci_setup
branch
from
3b2445b
to
c61cf5d
Compare
|
Code Climate has analyzed commit c61cf5d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 95.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CI workflow trigger
Change CI workflow to run on PRs. Prior to this, the trigger for a CI
build was a push to the repo. This meant that PRs from forks did not
trigger a CI run, so they could never meet the requirements of the
branch protection rules.
A repo maintainer must approve the workflow run for PRs from external
forks, in order to prevent abuse. This is already configured.
Restrict upload of code coverage report to Code Climate
Restrict the coverage report upload to builds triggered by:
pushes to master (these are mainly merges of PRs);
pushes of version number tags; and
PRs not raised from forks or by Dependabot
PRs from forks or Dependabot do not have access to the secrets needed
to upload the report to Code Climate, and there's no point tainting
their CI builds with failures from the coverage upload.
A few branch protection rules depended on the report being uploaded.
These have been removed so that PRs from forks and Dependabot can
actually pass CI.
Push a tag to set the gem version and build the gem
Pushing a tag of the format vX.Y.Z will trigger a CI test run and then
build the gem and push it to Ruby Gems if the tests pass. The gemspec
will automatically set the version number based on the tag.
This is done in a new job in the CI workflow. This requires access to
a secret but, as the workflow will have been triggered by a push, the
workflow will have access to the secrets in this case.