Revise coverage report workflow to generate the report too #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attempt to upload the code coverage report in a separate workflow has been an exercise in frustration. The initial plan was to generate the report in the test job of the CI workflow, save it as an artefact, then download the artefact in the coverage report workflow and upload it to Code Climate there. Unfortunately, for this to work the coverage report workflow needs to check out the revision of the repo on which the report was generated. Code Climate must associate the coverage report with the revision that generated so that it can calculate the coverage diffs for, and the only way in which the Code Climate action can get this is from the currently checked-out revision. Frankly, if we're going to have to check the revision out, we may as well just generate the report in this workflow too, and not mess around with artefacts. The tests don't take long to run, anyway.
|
Code Climate has analyzed commit 9387b34 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 95.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attempt to upload the code coverage report in a separate workflow has been an exercise in frustration.
The initial plan was to generate the report in the test job of the CI workflow, save it as an artefact, then download the artefact in the coverage report workflow and upload it to Code Climate there.
Unfortunately, for this to work the coverage report workflow needs to check out the revision of the repo on which the report was generated. Code Climate must associate the coverage report with the revision that generated so that it can calculate the coverage diffs for, and the only way in which the Code Climate action can get this is from the currently checked-out revision.
Frankly, if we're going to have to check the revision out, we may as well just generate the report in this workflow too, and not mess around with artefacts. The tests don't take long to run, anyway.