fix for Sinject::DependencyContractInvalidParametersException

[cosimaradu]

fix for Sinject::DependencyContractInvalidParametersException: The method signature of method: 'get' does not match the contract parameters: 'block'

[codeclimate]

Code Climate has analyzed commit b06446e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

[KevinBrowne]

What was this supposed to address? The description does not contain enough detail to understand that.

In any case, I believe that this change introduces a bug. If a contract class specifies keyrest args, and the concrete class doesn't, then the concrete class is not implementing the contract.

This contract states that #foo must accept any number of keyword arguments:

class Contract
  def foo(bar, **kwargs); end
end

This class does not satisfy the contract because it does not accept any number of keyword arguments, it accepts precisely one:

class Concrete
  def foo(bar, kwargs: nil); end
end

However, with this change the contract validation will now accept the class!

On the other hand, it will not accept this one because kwargs is keyreq:

class Concrete
  def foo(bar, kwargs:); end
end

I'm raising a bug for this, but if you're now depending on this behaviour, it's going to be difficult to fix it.