Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom kind icon color in get_kind_icon #1011

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krovuxdev
Copy link

No description provided.

@Saghen
Copy link
Owner

Saghen commented Jan 17, 2025

This was set to the block in #544 to make the color more visible. The Color key in kind_icons is set by default, so we would never use the block icon with this code as far as I can tell. Perhaps we could use a unique key for this like ColorPreview (feel free to change this, just an idea)

@Saghen
Copy link
Owner

Saghen commented Jan 17, 2025

Although, I'm also debating if we should instead provide a recipe for this and avoid adding a non-standard kind: #544 (comment)

@krovuxdev
Copy link
Author

@Saghen Thank you for the feedback. If I understand correctly, you’re suggesting that:

  • The Color key is already set by default, so it doesn’t need to be reused.
  • We could consider using a unique key like ColorPreview.

Is that correct?

I’ve updated the code to use a unique key ColorPreview instead of Color.

Please let me know if this approach works for you or if you have any additional suggestions. Thank you for the detailed feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants