-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add omnifunc
completion source
#1114
Conversation
A few thoughts:
|
I think this should be opt-in. Omni-completion seems to be a synchronous interface? And neovim will automatically set lsp as omni-func by default when lsp is attched and omni-func is not set by the users. Probably don't want to have double-lsp. |
The
By default I have
Either way, I don't disagree that it may make more sense for this to be opt-in. |
Thank you! Opt-in makes sense since the API is synchronous
I'm open to renaming this |
I think—at least for now—it might be best to leave it at |
Closes #1103