Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test nix build on push with linux & macos machines #332

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

vinnymeller
Copy link
Contributor

@vinnymeller vinnymeller commented Nov 14, 2024

wip

@Saghen
Copy link
Owner

Saghen commented Nov 15, 2024

on the other hand this isn't uploading artifacts like the others, more of just a test, so it doesn't fit super neatly into the release workflow

Yeah, I think it makes sense to run this on: push. Overall seems like a good idea!

@vinnymeller
Copy link
Contributor Author

@Saghen would you want a separate workflow to just run the nix build then? like .github/workflows/nix-build.yaml or something?

@Saghen
Copy link
Owner

Saghen commented Nov 15, 2024

Yeah that'd be great

@vinnymeller vinnymeller changed the title ci: test build with nix on linux/mac in release workflow ci: test nix build on push with linux & macos machines Nov 15, 2024
@Saghen Saghen merged commit abf781a into Saghen:main Nov 15, 2024
@Saghen
Copy link
Owner

Saghen commented Nov 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants