feat: improve auto_show flexibility #697
Merged
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR gives more control over when and where we show automatic completion. It does this with two public-facing changes: 1. `completion.menu.auto_show` can now be either a function in addition to a constant boolean. This gives users the ability to make more complex decisions about whether to automatically show completions. 2. `blink.cmp.Context` contains a new field -- `update_type`. This field provides additional information on what triggered the update. This allows users to vary behavior when completion is manually triggered (as opposed to being automatically triggered by keywords or trigger characters).
guill
force-pushed
the
context_update_type
branch
from
5fd7ac5 to
496e428
Compare
guill
commented
Dec 21, 2024
|
|
||
| -- check if we've entered insert mode on a trigger character | ||
| elseif insert_enter_on_trigger_character then | ||
| trigger.context = nil | ||
| trigger.show({ trigger_character = char_under_cursor }) | ||
| trigger.show({ trigger_character = char_under_cursor, update_type = 'auto_show_trigger_char' }) |
There was a problem hiding this comment.
We could have a separate update type for this -- interested in thoughts on whether that would actually be useful.
2 tasks
|
I believe the global |
2 tasks
Saghen
force-pushed
the
context_update_type
branch
from
2631f4b to
9b4b7af
Compare
|
I've also added an should_show_items = function(ctx) ctx.trigger.initial_kind ~= 'trigger_character' end |
|
Thank you! |
guill
added a commit
to guill/blink.cmp
that referenced
this pull request
Dec 21, 2024
This code was reduced by a line before merging PR Saghen#697, but it's now hitting the case where the Lua 'ternary' doesn't behave like a proper ternary operator. Specifically, when the `auto_show` function returns false, the result of ```lua auto_show = type(auto_show) == "function" and auto_show(...) or auto_show ``` becomes ```lua auto_show = (true and false) or <function> ``` which is the truthy function reference itself.
Saghen
pushed a commit
that referenced
this pull request
Dec 21, 2024
This code was reduced by a line before merging PR #697, but it's now hitting the case where the Lua 'ternary' doesn't behave like a proper ternary operator. Specifically, when the `auto_show` function returns false, the result of ```lua auto_show = type(auto_show) == "function" and auto_show(...) or auto_show ``` becomes ```lua auto_show = (true and false) or <function> ``` which is the truthy function reference itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives more control over when and where we show automatic completion. It does this with two public-facing changes:
completion.menu.auto_showcan now be either a function or a constant boolean. This gives users the ability to make more complex decisions about whether to automatically show completions.blink.cmp.Contextcontains a new field --update_type. This field provides additional information on what triggered the update. This allows users to vary behavior when completion is manually triggered (as opposed to being automatically triggered by keywords or trigger characters).