fix: correctly handle non-blink keymaps with string rhs #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following config:
Pressing
<S-Tab>
in insert mode when the Blink window is not visible creates an error:The issue is that
nvim_eval
is unconditionally called onmapping.rhs
, so this PR fixes the logic to only evaluate the result of<expr>
mappings.I also fixed a bug in the
if mapping
conditions, which are a little different in nvim-cmp because these fields are converted into boolean values.As you noted in a comment, handling fallback keymaps correctly in all cases is tricky, but for the moment, this should at least unblock a common case.