fix(cmdline): make completion work for <sid> and s: viml function

[rainerborene]

This branch fixes completion issues with commands like :Rename in plugins such as vim-eunuch. You can test it by running :Rename, and the completion should work without errors.

The issue was caused by s: and <sid> functions being scoped to their script, which led to errors like:

Error while fetching completions: Vim:E120: Using not in a script context: s:RenameComplete

This fix ensures proper handling of these functions, resolving the issue.

[rainerborene]

ping @Saghen

[Saghen]

Does this work with <sid> scripts used with input? The motivation for this getcmdcompltype() code was the following: #696 (comment). My knowledge of vimscript is very limited but does this case still work with an <sid> script? I'm likely missing a more elegant solution here (i.e. is there a vim.fn.getcompletion(_, mode) that gives completions in inputs?)

[rainerborene]

Yes, it works just fine. You cannot call a script context function. That’s why we must call it via getcompletion instead. I don’t understand why we should call it manually though. Maybe could we delegate to vim.fn.getcompletion instead?

…

On Thu, 9 Jan 2025 at 16:19 Liam Dyer ***@***.***> wrote: Does this work with <sid> scripts used with input? The motivation for this getcmdcompltype() code was the following: #696 (comment) <#696 (comment)>. I'm not familiar with vimscript but does this case still work with an <sid> script? I'm likely missing a more elegant solution here (i.e. is there a vim.fn.getcompletion(_, mode) that gives completions in inputs?) — Reply to this email directly, view it on GitHub <#925 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYY7LYQ2GVNFLB5L2UU5L2J3DS7AVCNFSM6AAAAABUWUYZ32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRGA3TMMBYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Saghen]

Try the linked code snippet with vim.fn.getcompletion(query, 'cmdline') and it shouldn't return the correct completions, hence the workaround with getcmdcompltype

[rainerborene]

I'm sorry for the dumb question. Why input has anything to do with cmdline? I did the following test and it works:

function! s:LocalAutocomplete(A,L,P) abort
  return ['one', 'two', 'three']
endfunction

function! s:StillComplete(A,L,P) abort
  return ['one', 'two', 'three']
endfunction

command! -nargs=1 -complete=customlist,s:LocalAutocomplete LocalComplete echo 'oi'
command! -nargs=1 -complete=customlist,<sid>StillComplete StillComplete echo 'oi'

lua =vim.fn.getcompletion("StillComplete ", "cmdline")
" => { "one", "two", "three" }

Edit: Oh, I think I got your point. My changes does not break the input completion at all because as I said you cannot call s: and <sid> functions in the first place.

[rainerborene]

Hmm. Maybe it works because I had to insert an extra space to complete it?

This works:

lua =vim.fn.getcompletion("StillComplete ", "cmdline")

But this won't work:

lua =vim.fn.getcompletion("StillComplete", "cmdline")

[Saghen]

Thank you!