-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Improve Event Service Efficiency by Removing Direct Calls to Friends Service in Get Event Handler #427
Labels
Comments
This issue will also be aligned with the Paralax development.
|
@SaintAngeLs, I remember you've mentioned the nullable values in convert query method in Paralax. it has nothing to deal with it. The issue is that the Organizer(Enumerator Type).OrganizationId(Also nullable Type) is compared as the string to Guid. |
SaintAngeLs
added a commit
that referenced
this issue
Oct 3, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 6, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 6, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 6, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 6, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 6, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 6, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 11, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 11, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 11, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 11, 2024
SaintAngeLs
added a commit
that referenced
this issue
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Currently, the Event Service is making direct calls to the Friends Service in the
GetEventHandler
whenever an event is fetched. This process introduces unnecessary latency and potential points of failure, as the entire event retrieval process is dependent on the availability and response time of the Friends Service. This inefficiency affects the performance of the Event Service, especially when handling requests at scale.Problem:
When the Event Service queries an event, it calls the Friends Service to retrieve the friends data of the user requesting the event. This dependency introduces the following issues:
GetEvent
query is extended by the need to call the Friends Service.GetEvent
request, even when the friends data is not critical for all use cases.Proposed Solution:
Refactor the Event Service to decouple the Friends Service calls from the
GetEvent
query:GetEventHandler
should no longer call the Friends Service when retrieving events.GetEvent
query.Alternatives Considered:
Additional Context:
The text was updated successfully, but these errors were encountered: