cryptex lite for Navi CLI #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [FIX] Divide by zero issue in controller - [FIX] Index out of bounds error in cryptex - [UPDATE] affn - [UPDATE] ak - [UPDATE] b64 - [UPDATE] Test structure
hullabaloo-vincent
changed the title
hullabaloo-vincent
changed the title
AlexKollar
reviewed
Jun 24, 2024
There was a problem hiding this comment.
There were a few things I noticed as we went. At this point its more missing features more so than bugs.
- Ability to get a general --help running (We used to have it setup that if you ran the cipher without any additional context it would crank out a help menu for that cipher so if you didnt know how to use it you could get a quick ref)
- Ability to accept -i /path/to/file.txt
Aside of those, I think we are pretty well good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclusion of a lightweight cryptex app.