Document why macros have been used.

Sajjon · Feb 1, 2024 · 5ba98a0 · 5ba98a0
1 parent 1ff32e8
commit 5ba98a0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/profile/src/v100/entity/persona/persona_data/persona_data_identified_collection_types.rs b/profile/src/v100/entity/persona/persona_data/persona_data_identified_collection_types.rs
@@ -1,5 +1,8 @@
 use crate::prelude::*;
 
+// We have to use macros since UniFFI does not support generics, that is the only
+// reason this macro exists, if/when UniFFI supports generics, this macro should
+// be replaced by `CollectionOfIdentifiedPersonaDataEntries<T>`.
 macro_rules! declare_collection_of_identified_entry {
     ($id_ent_type:ty,$struct_name:ident) => {
         /// A collection of identifiable PersonaData Entries.

diff --git a/profile/src/v100/entity/persona/persona_data/persona_data_identified_entry_types.rs b/profile/src/v100/entity/persona/persona_data/persona_data_identified_entry_types.rs
@@ -4,6 +4,9 @@ pub trait PersonaDataEntryValue: From<Self::Value> {
     type Value;
 }
 
+// We have to use macros since UniFFI does not support generics, that is the only
+// reason this macro exists, if/when UniFFI supports generics, this macro should
+// be replaced by `PersonaDataIdentifiedEntry<T>`.
 macro_rules! declare_identified_entry {
     ($value_type:ty,$struct_name:ident) => {
         #[derive(

diff --git a/profile/src/v100/networks/network/authorized_dapp/shared_with_dapp.rs b/profile/src/v100/networks/network/authorized_dapp/shared_with_dapp.rs
@@ -1,5 +1,8 @@
 use crate::prelude::*;
 
+// We have to use macros since UniFFI does not support generics, that is the only
+// reason this macro exists, if/when UniFFI supports generics, this macro should
+// be replaced by `SharedToDappWithPersonaIDs<T>`.
 macro_rules! declare_shared_with_dapp {
     ($id:ty,$struct_name:ident) => {
         /// IDs that have been shared with an Dapp the user has interacted with