This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Wallet API & New Error / Result & prelude & log & derive Display/Debug #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing back to manual impl of Serde for Acccount Address
Sajjon
changed the title
Swift bindgen test
Wallet API & use crate::prelude everywhere & derive_more::Display / Debug
Jan 15, 2024
Sajjon
changed the title
Wallet API & use crate::prelude everywhere & derive_more::Display / Debug
Wallet API && use crate::prelude everywhere && log && derive_more::Display & Debug
Jan 15, 2024
Sajjon
changed the title
Wallet API && use crate::prelude everywhere && log && derive_more::Display & Debug
Wallet API & New Error / Result & prelude & log & derive Display/Debug
Jan 15, 2024
Sajjon
force-pushed
the
swift_bindgen_test
branch
from
January 20, 2024 07:00
687fb7b
to
310a490
Compare
…ference in rustfmt output between Mac Intel and Mac Silicon: rust-lang/rustfmt#5964
SLIP10 & CAP26 test vectors impl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big PR:
use crate::prelude::*;
everywhere ( -2000 lines of trivial "use" code)Wallet
APIWallet
APISecureStorage
andWalletClientStorage
CommonError
and give each case an error code! (Rust enums are even more powerful than Swift ones, they can have BOTH associated values AND raw value!) - will rename it to just Error in coming PR.type Result<T, E = CommonError> = Result<T, E>
everywherelog
andenv_logger
derive_more
's ability to derive Display and Debugserde_with
instead of manual impl of serde, most prominatlySerializeDisplay
andDeserializeFromStr
nightly-2023-11-24
tonightly-2024-01-11
(arbitarily chosen) trying to fixrustfmt 1.7.0-nightly
inconsistent output across targets rust-lang/rustfmt#5964 issue we have between Mac Intel and Mac Silicon - also adding arustfmt.toml
file, same settings as in RETcargo fmt
- so review wants to exclude the last commit 471a939