feat: adding destroy and options object (noir-lang#3105)

Sakapoi · Oct 19, 2023 · 17332ee · 17332ee
1 parent 18d4e9c
commit 17332ee
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/tooling/noir_js/src/program.ts b/tooling/noir_js/src/program.ts
@@ -19,6 +19,10 @@ export class Noir {
     }
   }
 
+  async destroy(): Promise<void> {
+    await this.backend?.destroy();
+  }
+
   private getBackend(): Backend {
     if (this.backend === undefined) throw new Error('Operation requires a backend but none was provided');
     return this.backend;

diff --git a/tooling/noir_js_backend_barretenberg/src/index.ts b/tooling/noir_js_backend_barretenberg/src/index.ts
@@ -2,6 +2,7 @@
 import { decompressSync as gunzip } from 'fflate';
 import { acirToUint8Array } from './serialize.js';
 import { Backend, CompiledCircuit, ProofData } from '@noir-lang/types';
+import { BackendOptions } from './types.js';
 
 // This is the number of bytes in a UltraPlonk proof
 // minus the public inputs.
@@ -15,11 +16,12 @@ export class BarretenbergBackend implements Backend {
   private api: any;
   private acirComposer: any;
   private acirUncompressedBytecode: Uint8Array;
-  private numberOfThreads = 1;
 
-  constructor(acirCircuit: CompiledCircuit, numberOfThreads = 1) {
+  constructor(
+    acirCircuit: CompiledCircuit,
+    private options: BackendOptions = { threads: 1 },
+  ) {
     const acirBytecodeBase64 = acirCircuit.bytecode;
-    this.numberOfThreads = numberOfThreads;
     this.acirUncompressedBytecode = acirToUint8Array(acirBytecodeBase64);
   }
 
@@ -28,7 +30,7 @@ export class BarretenbergBackend implements Backend {
       // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       //@ts-ignore
       const { Barretenberg, RawBuffer, Crs } = await import('@aztec/bb.js');
-      const api = await Barretenberg.new(this.numberOfThreads);
+      const api = await Barretenberg.new(this.options.threads);
 
       const [_exact, _total, subgroupSize] = await api.acirGetCircuitSizes(this.acirUncompressedBytecode);
       const crs = await Crs.new(subgroupSize + 1);

diff --git a/tooling/noir_js_backend_barretenberg/src/types.ts b/tooling/noir_js_backend_barretenberg/src/types.ts
@@ -0,0 +1,3 @@
+export type BackendOptions = {
+  threads: number;
+};
diff --git a/tooling/noir_js_types/src/types.ts b/tooling/noir_js_types/src/types.ts
@@ -10,8 +10,8 @@ export interface Backend {
   generateIntermediateProof(decompressedWitness: Uint8Array): Promise<ProofData>;
 
   verifyFinalProof(proofData: ProofData): Promise<boolean>;
-
   verifyIntermediateProof(proofData: ProofData): Promise<boolean>;
+  destroy(): Promise<void>;
 }
 
 export type ProofData = {