Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lottery_schemaに「抽選期間終了の時間」を含める #163

Closed
2 tasks done
Cj-bc opened this issue Sep 8, 2018 · 5 comments
Closed
2 tasks done

Lottery_schemaに「抽選期間終了の時間」を含める #163

Cj-bc opened this issue Sep 8, 2018 · 5 comments
Assignees
@Cj-bc
Labels
enhancement New feature or request

Comments

@Cj-bc
Copy link
Member

Cj-bc commented Sep 8, 2018 •
edited
Loading

Step 1: 目的

  • frontに、いつリロードすれば良いのか伝える
  • その後の利用方法はfront次第ですが、個人的には、ユーザーにhh:mm に発表されますと表示したりすると良いのではないかなと思っています。

Step 2: 概要

  • 該当lotteryのindexのTIME_POINT + DRAWING_TIME_EXTENSIONを含める

関連するコード:

  • api/schemas.py

タスク:

  • フィールド名決定( @Sakuten/frontend と協議)
  • Lottery_schemaに上記フィールドを追加する
@Cj-bc Cj-bc added the enhancement New feature or request label Sep 8, 2018
@Cj-bc
Copy link
Member Author

Cj-bc commented Sep 8, 2018

んで、fieldの名前なのですが何がいいですかね？？
自分的には、annoucement_of_resultとかかなぁと思っとります

@coord-e coord-e mentioned this issue Sep 8, 2018
Closed
@Cj-bc Cj-bc mentioned this issue Sep 8, 2018
Open
@Cj-bc
Copy link
Member Author

Cj-bc commented Sep 8, 2018

フィールド名については、特に応答がないのでend_of_drawingにしておきます。

Cj-bc added a commit that referenced this issue Sep 8, 2018
@Cj-bc
Add: (refs #163) api/schema> add 'end_of_drawing' to Lottery schema
bb5aba9
@Cj-bc Cj-bc mentioned this issue Sep 8, 2018
Merged
@Cj-bc Cj-bc self-assigned this Sep 8, 2018
@Cj-bc
Copy link
Member Author

Cj-bc commented Sep 8, 2018

PR: #175

@Cj-bc
Copy link
Member Author

Cj-bc commented Sep 9, 2018

branch: feature/163-add-end-of-drawing-to-lottery-schema

@Cj-bc
Copy link
Member Author

Cj-bc commented Sep 9, 2018

close with merging of #175

@Cj-bc Cj-bc closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cj-bc Cj-bc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cj-bc