WIP: Resolve #165: Classroomに劇の時間を追加 #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 7, 2020
| with client.application.app_context(): | ||
| target_classroom = Classroom.query.first() | ||
|
|
||
| dumpdata = classroom_schema.dump(target_classroom) |
There was a problem hiding this comment.
indentation contains mixed spaces and tabs
undefined name 'classroom_schema'
| def test_classroom_time(client): | ||
| with client.application.app_context(): | ||
| target_classroom = Classroom.query.first() | ||
|
|
There was a problem hiding this comment.
blank line contains whitespace
indentation contains mixed spaces and tabs
indentation contains tabs
|
|
||
| def test_classroom_time(client): | ||
| with client.application.app_context(): | ||
| target_classroom = Classroom.query.first() |
| @@ -48,6 +48,9 @@ class Classroom(db.Model): | |||
| grade = db.Column(db.Integer) | |||
| index = db.Column(db.Integer) | |||
| title = db.Column(db.String(300)) | |||
| begin_time = db.Column(db.Time) | |||
| end_time = db.Column(db.Time) | |||
|
|
|||
|
Code Climate has analyzed commit 9057964 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容
劇の発表時間をclassroomに紐づける #165
修正前の挙動:
修正後の挙動:
影響範囲