-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Super-Linter Bash linting errors #329
Conversation
2884e25
to
cc2f1ac
Compare
cc @jbampton |
Why closed? |
Hey @BDadmehr0 I just added you to the triage team https://github.com/orgs/SalamLang/teams https://github.com/orgs/SalamLang/teams/triage/repositories |
Thanks for adding me to the triage team! Could you please let me know more about my responsibilities or next steps? |
Hey @BDadmehr0 basically you just got higher permissions and we hope you will help out more. By triage we mean interact with contributors on issues and PRs and also fill in the missing details for:
Some of those get auto filled on PRs but we can always make that smarter too. Example shown below Thanks once again. |
Description
This pull request updates the Bash build script to resolve linting issues flagged by
ShellCheck
and improves its overall robustness. The changes enhance readability, modernize command usage, and ensure compliance with best practices.Related Issue
This PR addresses Issue #321 (Super-Linter Bash linting errors).
Proposed Changes
$?
) with direct command checks usingif !
to resolveSC2181
../
to resolveSC2035
and avoid unintended matches.