Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Super-Linter Bash linting errors #329

Closed
wants to merge 4 commits into from

Conversation

BDadmehr0
Copy link
Member

Description

This pull request updates the Bash build script to resolve linting issues flagged by ShellCheck and improves its overall robustness. The changes enhance readability, modernize command usage, and ensure compliance with best practices.

Related Issue

This PR addresses Issue #321 (Super-Linter Bash linting errors).

Proposed Changes

  • Replaced indirect exit code checks ($?) with direct command checks using if ! to resolve SC2181.
  • Updated glob patterns to prefix with ./ to resolve SC2035 and avoid unintended matches.
  • Enhanced readability by restructuring sections and adding spacing.
  • Preserved functionality, including optional cleanup of object files.

@jbampton jbampton self-assigned this Nov 23, 2024
@jbampton jbampton added this to the November milestone Nov 23, 2024
@jbampton jbampton marked this pull request as draft November 23, 2024 07:12
@BaseMax
Copy link
Member

BaseMax commented Nov 23, 2024

cc @jbampton

@BDadmehr0 BDadmehr0 closed this Nov 25, 2024
@BDadmehr0 BDadmehr0 deleted the Super-Linter-Bash branch November 25, 2024 14:05
@BDadmehr0 BDadmehr0 restored the Super-Linter-Bash branch November 25, 2024 14:05
@jbampton
Copy link
Member

Why closed?

@jbampton
Copy link
Member

@BDadmehr0 BDadmehr0 deleted the Super-Linter-Bash branch November 25, 2024 15:06
@BDadmehr0
Copy link
Member Author

Hey @BDadmehr0 I just added you to the triage team

https://github.com/orgs/SalamLang/teams

https://github.com/orgs/SalamLang/teams/triage/repositories

Thanks for adding me to the triage team! Could you please let me know more about my responsibilities or next steps?

@jbampton
Copy link
Member

Hey @BDadmehr0 basically you just got higher permissions and we hope you will help out more.

By triage we mean interact with contributors on issues and PRs and also fill in the missing details for:

  • Assignees
  • Labels
  • Projects
  • Milestones

Some of those get auto filled on PRs but we can always make that smarter too.

Example shown below

Thanks once again.

Screenshot from 2024-11-26 05-59-40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants