Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Namespace /mobify #1795

Closed
wants to merge 12 commits into from
Closed

[SPIKE] Namespace /mobify #1795

wants to merge 12 commits into from

Conversation

vcua-mobify
Copy link
Contributor

@vcua-mobify vcua-mobify commented May 21, 2024

This is a POC of #1767

This PR shows how we can use the site alias defined in default.js as a namespace for the /mobify paths and for entries in local storage / cookie storage.

The document for this spike can be seen here: https://salesforce.quip.com/RaYKAunGpS3K

Testing this POC:

  1. Check out the code base
  2. Set an env variable called LOCAL_ENV_NAMESPACE to global
  3. Start the app. See that /mobify paths are namespaced. ie. /global/mobify/...
  4. Create a local.js config file and set the default site to RefArch
  5. Set LOCAL_ENV_NAMESPACE to us
  6. Restart the app. See that /mobify paths have a different namespace. ie. /us/mobify/...

@vcua-mobify vcua-mobify added the do not merge No matter what, do not merge this pr label May 21, 2024
@vcua-mobify vcua-mobify requested a review from a team as a code owner May 21, 2024 20:09
@vcua-mobify
Copy link
Contributor Author

#1824, which sets the stage for adding a namespace has been merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge No matter what, do not merge this pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant