Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added app builder configuration for "show legend" to toggle display o… #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psuslick
Copy link

…f chart legend

To address concerns which were raised in issue #39 (#39) this feature adds an ability for the app builder to toggle display of the legend on or off.

Description

To address concerns which were raised in issue #39 (#39) this feature adds an ability for the app builder to toggle display of the legend on or off.

Motivation and Context

End users were met with undesirable and unintended charts displays when attempting to utilize the app builder component with SOQL statements.

This change allows for charts made using the app builder to hide the legend when the query returns it as "undefined."

#39

How Has This Been Tested?

The feature has been shown to work across multiple scratch orgs and app builder configurations.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…f chart legend

To address concerns which were raised in issue SalesforceLabs#39 (SalesforceLabs#39) this feature adds an ability for the app builder to toggle display of the legend on or off.
Copy link
Collaborator

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(test): improve test for the new attribute

We should add a dedicated jest test in __tests__/unit/chartBuilder.test.js for the newly created attribute

@victorgz victorgz mentioned this pull request Jan 17, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants