Fix broken wwatch3 figures generation #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model fields dataset can now be opened directly from ERDDAP by xarray; much faster :-)
No need to go as low level as xarray.Dataset.values.
pandas seems to be pickier than it used to be about how column names are specified; perhaps something to do with MulitIndex changes.
re: changes in wave_height_period sig module.
|
Successfully tested in production. |
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 72.95% 72.99% +0.04%
==========================================
Files 122 122
Lines 16039 16026 -13
Branches 1306 1305 -1
==========================================
- Hits 11701 11698 -3
+ Misses 4287 4277 -10
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the breaked was fixed in UBC-MOAD/moad_tools#19 and some here.
Also included here is elimination of the work-around for OpenDAP not being able to open the wwatch3
fields dataset directly from ERDDAP. Result of that is much faster code now :-)