Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for after_*() functions & missing after_archive_tarball() #107

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

douglatornell
Copy link
Member

New test inspects next_workers module to confirm that it contains an after_*() function
for each of the worker modules in nowcast/workers/.

Prompted by having missed the addition of the after_archive_tarball() function in PR#104.

@douglatornell douglatornell self-assigned this Jun 7, 2022
@douglatornell douglatornell added bug Something isn't working Framework Workers labels Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #107 (40478f7) into main (bf9fddb) will decrease coverage by 0.00%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   73.81%   73.81%   -0.01%     
==========================================
  Files         125      125              
  Lines       16249    16266      +17     
  Branches     1320     1326       +6     
==========================================
+ Hits        11995    12007      +12     
- Misses       4202     4205       +3     
- Partials       52       54       +2     
Flag Coverage Δ
unittests 73.81% <70.58%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_next_workers.py 99.03% <66.66%> (-0.69%) ⬇️
nowcast/next_workers.py 98.36% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9fddb...40478f7. Read the comment docs.

@douglatornell douglatornell added this to the v22.1 milestone Jun 7, 2022
@douglatornell douglatornell merged commit 48d3c2d into main Jun 7, 2022
@douglatornell douglatornell deleted the test_after_funcs branch June 7, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Framework Workers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant