Add USGS rivers to collect_river_data
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modernized alternative to requests.
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 73.92% 74.13% +0.20%
==========================================
Files 127 127
Lines 16682 16805 +123
Branches 1183 1189 +6
==========================================
+ Hits 12333 12458 +125
+ Misses 4299 4297 -2
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
monkeypatch has a more explicit API, and is less magical than unittest.mock.patch.
Make calculation function specific to ECCC river observation CSV files in preparation for addition of REST query function for USGS rivers.
httpx_mock pytest fixture for unit tests.
Because production tests show that values are not available at PST time when [collect|download]_weather 06 runs.
|
Successfully tested in production on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SalishSeaCast NEMO v202111 uses many more observed river discharges than previous versions. So,
collect_river_dataneeds to learn how to collect data from https://waterservices.usgs.gov/