Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wwatch3 prep & runs date propagation #175

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

douglatornell
Copy link
Member

Off-by-1 errors suck!

@douglatornell douglatornell added bug Something isn't working Workflow labels Apr 8, 2023
@douglatornell douglatornell added this to the v23.1 milestone Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #175 (238f79b) into main (352961a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files         129      129           
  Lines       17195    17195           
  Branches     1214     1214           
=======================================
  Hits        13070    13070           
  Misses       4076     4076           
  Partials       49       49           
Flag Coverage Δ
unittests 76.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_next_workers.py 99.74% <ø> (ø)
nowcast/next_workers.py 97.98% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglatornell
Copy link
Member Author

Tested successfully in production on9-Apr-2023.

@douglatornell douglatornell merged commit c34641f into main Apr 9, 2023
@douglatornell douglatornell deleted the fix-ww3-date-propagation branch April 9, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant