Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sarrcenia clients to use queues on dd.weather.gc.ca #180

Merged
merged 6 commits into from
May 11, 2023

Conversation

douglatornell
Copy link
Member

This was done as an ad hoc change on 25-Apr-2023 to avoid disruption due to expected hpfx server maintenance.
However, the missing file messages and duplicated files issues in HRDPS downloads
that started with the change to the continental rotated lat-lon grid in Feb-2023
disappeared with the change to dd.weather.gc.ca.
So, this PR makes the change official.

Distinguish it from config for hpfx..collab.science.gc.ca.

Add directives for queue name, number of instances, and message expiry re:
sarracenia docs recommended config elements.
Perhaps multiple instances contribute to missing file messages and duplicated
files issues?
Was done on 25-Apr-2023 to avoid disruption due to hpfx server maintenance.
However, missing file messages and duplicated files issues in HRDPS downloads
that started with the change to the continental rotated lat-lon grid in Feb-2023
disappeared with the change to dd.weather.gc.ca.
@douglatornell douglatornell added config Automation configuration sarracenia Affects Sarracenia ECCC AMQP client labels May 10, 2023
@douglatornell douglatornell added this to the v23.1 milestone May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #180 (0296af8) into main (28aab1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files         129      129           
  Lines       17195    17195           
  Branches     1865     1865           
=======================================
  Hits        13070    13070           
  Misses       4076     4076           
  Partials       49       49           
Flag Coverage Δ
unittests 76.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@douglatornell douglatornell merged commit ceddac3 into main May 11, 2023
@douglatornell douglatornell deleted the sarracenia-dd-weather branch May 11, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Automation configuration sarracenia Affects Sarracenia ECCC AMQP client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant