Add --backfill option to crop_gribs worker
#216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`crop_gribs --backfill` option is for use for recovery from automation failures. Additionally, added a condition to skip cropping the GRIB files when SalishSeaCast subdomain files exist, which is reported as a debug message. That will optimize the cropping process by avoiding redundancy. Tests were updated to reflect these changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 77.73% 77.78% +0.05%
==========================================
Files 133 133
Lines 18724 18770 +46
Branches 1910 1916 +6
==========================================
+ Hits 14555 14601 +46
Misses 4110 4110
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crop_gribs --backfilloption is for use for recovery from automation failures. Additionally, added a condition to skip cropping the GRIB files when SalishSeaCast subdomain files exist, which is reported as a debug message. That will optimize the cropping process by avoiding redundancy. Tests were updated to reflect these changes.