Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download_live_ocean re: sentinel file chg #84

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

douglatornell
Copy link
Member

Parker's automation change on 9-Nov-2021 changed the content of the sentinel
file that indicates that the netCDF file is ready to download.
New file contains just the date/time when the netCDF file is ready.

Also, improve production config unit tests.

Parker's automation change on 9-Nov-2021 changed the content of the sentinel
file that indicates that the netCDF file is ready to download.
New file contains just the date/time when the netCDF file is ready.
@douglatornell douglatornell self-assigned this Nov 10, 2021
@douglatornell douglatornell added bug Something isn't working maintenance Codebase maintenance labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #84 (cdf9e8a) into main (7af9425) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   72.89%   72.91%   +0.02%     
==========================================
  Files         122      122              
  Lines       15984    15982       -2     
  Branches      956      953       -3     
==========================================
+ Hits        11651    11653       +2     
+ Misses       4283     4279       -4     
  Partials       50       50              
Flag Coverage Δ
unittests 72.91% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nowcast/workers/download_live_ocean.py 78.94% <0.00%> (+3.94%) ⬆️
tests/workers/test_download_live_ocean.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af9425...cdf9e8a. Read the comment docs.

@douglatornell douglatornell merged commit 89b7d92 into main Nov 10, 2021
@douglatornell douglatornell deleted the fix-download_live_ocean branch November 10, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Codebase maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant