Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to laravel 10 VEN-49 #214

Merged
merged 6 commits into from
Jul 23, 2023
Merged

Upgrade to laravel 10 VEN-49 #214

merged 6 commits into from
Jul 23, 2023

Conversation

jamalla2
Copy link
Contributor

No description provided.

HazemKhaled
HazemKhaled requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@HazemKhaled HazemKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to also update package.json to the latest laravel-mix

@HazemKhaled HazemKhaled changed the title Upgrade to laravel 10 Upgrade to laravel 10 VEN-49 Jul 23, 2023
@jamalla2
Copy link
Contributor Author

I believe you need to also update package.json to the latest laravel-mix

For the laravel-mix package, the current starter-kit uses laravel-mix 6.0.49, which is the latest version:
npm: laravel-mix
GitHub - laravel-mix/laravel-mix: The power of webpack, distilled for the rest of us.

However, according to Laravel 10 documentation, Vite has replaced Laravel Mix:
Laravel - The PHP Framework For Web Artisans

Shall i proceed with switching to Vite?

@salkhwlani salkhwlani merged commit a82816e into master Jul 23, 2023
@salkhwlani salkhwlani deleted the upgrade-to-laravel-10 branch July 23, 2023 19:27
@salkhwlani
Copy link
Member

@jamalla2 yes please

@HazemKhaled
Copy link
Member

@salahmyn Let's pause moving to Vit since we can't validate chunking bundles approaches are supported in microfrontend frameworks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazemKhaled HazemKhaled HazemKhaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamalla2 @salkhwlani @HazemKhaled @jamalla