-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDR support - environment and image based lighting. #72
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of quick comments and the file conflicts will also have to get resolved at some point
storageMemoize(async () => { | ||
const { default: hdr } = await import( | ||
// @ts-ignore | ||
/* webpackChunkName: "Environment" */ "../../assets/models/textures/Environment/Environment.hdr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this made it into SharedAssets yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I haven't finished final render yet, current environment texture is a testrender I made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is okay to put the test render in. It is honestly high quality enough for temporary use.
@Abbondanzo is there a way to flag the render under beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to flag the render under beta?
Not entirely, but we can flag the version number in package.json
as 0.7.0b
or something of that nature. Publishing only happens once we cut releases in this repo
This pull request introduces 1 alert when merging f77aea6 into d67de56 - view on LGTM.com new alerts:
|
Fixes #64