Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump detection (no demo), and analysis. #250

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Bump detection (no demo), and analysis. #250

wants to merge 17 commits into from

Conversation

DivvyCr
Copy link
Contributor

@DivvyCr DivvyCr commented Jul 31, 2020

Attempt 1 at finding all player contact in a game; then, determining who was the attacker/victim.

@DivvyCr
Copy link
Contributor Author

DivvyCr commented Jul 31, 2020

Noticed Issue #56 and wanted to try my hand at developing an actual feature, lol

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2020

This pull request introduces 3 alerts when merging baf33dc into 5d4385d - view on LGTM.com

new alerts:

  • 2 for Unused local variable
  • 1 for Wrong number of arguments in a call

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2020

This pull request introduces 2 alerts when merging 3d989c3 into 07297fe - view on LGTM.com

new alerts:

  • 2 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #250 into master will increase coverage by 0.18%.
The diff coverage is 98.98%.

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   90.79%   90.97%   +0.18%     
==========================================
  Files          99       99              
  Lines        4441     4531      +90     
  Branches      746      760      +14     
==========================================
+ Hits         4032     4122      +90     
  Misses        297      297              
  Partials      112      112              

@DivvyCr DivvyCr changed the title Bump detection (no demo), and analysis. WIP Bump detection (no demo), and analysis. Aug 3, 2020
@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2020

This pull request fixes 1 alert when merging 38d8ef9 into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2020

This pull request fixes 1 alert when merging aa9bd9f into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@DivvyCr
Copy link
Contributor Author

DivvyCr commented Aug 3, 2020

The current version should be more or less deployable, but it needs testing (no clue how do make those).

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2020

This pull request fixes 1 alert when merging 6922200 into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

NOTE: Have to change demo test, because game_stats.bumps is now more populated.
@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2020

This pull request fixes 1 alert when merging d847e75 into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2020

This pull request fixes 1 alert when merging cf987f5 into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@DivvyCr
Copy link
Contributor Author

DivvyCr commented Aug 6, 2020

All tests fail... 3_BUMPS asserts 5==3, and 4_BUMPS asserts 2==4 (even though 1 of the bumps is a demo, so it should be 3==4)

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2020

This pull request fixes 1 alert when merging eadf10e into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2020

This pull request fixes 1 alert when merging 719b9e8 into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@DivvyCr DivvyCr changed the title WIP Bump detection (no demo), and analysis. Bump detection (no demo), and analysis. Aug 6, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 8, 2020

This pull request fixes 1 alert when merging 7be3305 into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@lgtm-com
Copy link

lgtm-com bot commented Aug 8, 2020

This pull request fixes 1 alert when merging 04044a1 into 07297fe - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2020

This pull request fixes 1 alert when merging 4305e0e into 3e66f17 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@AppVeyorBot
Copy link

1 similar comment
@AppVeyorBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants