-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump detection (no demo), and analysis. #250
base: master
Are you sure you want to change the base?
Conversation
… who was the attacker/victim.
Noticed Issue #56 and wanted to try my hand at developing an actual feature, lol |
This pull request introduces 3 alerts when merging baf33dc into 5d4385d - view on LGTM.com new alerts:
|
❌ Build carball 0.6.100-lcncmcor failed (commit e9226d1d7d by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.100-lcncmcor failed (commit e9226d1d7d by @DivvyCr) |
This pull request introduces 2 alerts when merging 3d989c3 into 07297fe - view on LGTM.com new alerts:
|
✅ Build carball 0.6.101-gdrotuvx completed (commit c0bb6da14c by @DivvyCr) |
1 similar comment
✅ Build carball 0.6.101-gdrotuvx completed (commit c0bb6da14c by @DivvyCr) |
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 90.79% 90.97% +0.18%
==========================================
Files 99 99
Lines 4441 4531 +90
Branches 746 760 +14
==========================================
+ Hits 4032 4122 +90
Misses 297 297
Partials 112 112 |
❌ Build carball 0.6.101-hjxlskdv failed (commit b30a305be7 by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.101-hjxlskdv failed (commit b30a305be7 by @DivvyCr) |
This pull request fixes 1 alert when merging 38d8ef9 into 07297fe - view on LGTM.com fixed alerts:
|
❌ Build carball 0.6.101-vyliihkf failed (commit 4ede9a9454 by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.101-vyliihkf failed (commit 4ede9a9454 by @DivvyCr) |
This pull request fixes 1 alert when merging aa9bd9f into 07297fe - view on LGTM.com fixed alerts:
|
The current version should be more or less deployable, but it needs testing (no clue how do make those). |
This pull request fixes 1 alert when merging 6922200 into 07297fe - view on LGTM.com fixed alerts:
|
✅ Build carball 0.6.101-fxiwnpmf completed (commit 6c9b0dfa41 by @DivvyCr) |
1 similar comment
✅ Build carball 0.6.101-fxiwnpmf completed (commit 6c9b0dfa41 by @DivvyCr) |
NOTE: Have to change demo test, because game_stats.bumps is now more populated.
This pull request fixes 1 alert when merging d847e75 into 07297fe - view on LGTM.com fixed alerts:
|
❌ Build carball 0.6.101-rapknfwv failed (commit a30a5e6991 by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.101-rapknfwv failed (commit a30a5e6991 by @DivvyCr) |
❌ Build carball 0.6.102-xbnshkpx failed (commit 80a361ff83 by @DivvyCr) |
❌ Build carball 0.6.102-diqfkbyo failed (commit b5fd40febf by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.102-diqfkbyo failed (commit b5fd40febf by @DivvyCr) |
This pull request fixes 1 alert when merging cf987f5 into 07297fe - view on LGTM.com fixed alerts:
|
All tests fail... 3_BUMPS asserts 5==3, and 4_BUMPS asserts 2==4 (even though 1 of the bumps is a demo, so it should be 3==4) |
This pull request fixes 1 alert when merging eadf10e into 07297fe - view on LGTM.com fixed alerts:
|
❌ Build carball 0.6.102-pnhvitcw failed (commit 5884a83f46 by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.102-pnhvitcw failed (commit 5884a83f46 by @DivvyCr) |
❌ Build carball 0.6.102-ehlucbfj failed (commit 53c643c23b by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.102-ehlucbfj failed (commit 53c643c23b by @DivvyCr) |
This pull request fixes 1 alert when merging 719b9e8 into 07297fe - view on LGTM.com fixed alerts:
|
✅ Build carball 0.6.102-xyracdij completed (commit f6c7756871 by @DivvyCr) |
1 similar comment
✅ Build carball 0.6.102-xyracdij completed (commit f6c7756871 by @DivvyCr) |
…code for codecov)
This pull request fixes 1 alert when merging 7be3305 into 07297fe - view on LGTM.com fixed alerts:
|
❌ Build carball 0.6.104-akrapwpy failed (commit 5f228dc739 by @DivvyCr) |
1 similar comment
❌ Build carball 0.6.104-akrapwpy failed (commit 5f228dc739 by @DivvyCr) |
…code for codecov)
This pull request fixes 1 alert when merging 04044a1 into 07297fe - view on LGTM.com fixed alerts:
|
✅ Build carball 0.6.104-wnqrtcii completed (commit 3a369c2053 by @DivvyCr) |
1 similar comment
✅ Build carball 0.6.104-wnqrtcii completed (commit 3a369c2053 by @DivvyCr) |
This pull request fixes 1 alert when merging 4305e0e into 3e66f17 - view on LGTM.com fixed alerts:
|
✅ Build carball 0.6.117-aegdhlay completed (commit b44c830c32 by @Sciguymjm) |
1 similar comment
✅ Build carball 0.6.117-aegdhlay completed (commit b44c830c32 by @Sciguymjm) |
Attempt 1 at finding all player contact in a game; then, determining who was the attacker/victim.