Add postgres in docker #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hexponent
force-pushed
the
docker-postgres
branch
from
06b7c77
to
f9a75d3
Compare
|
Great, will merge when our Postgres is ready |
hexponent
force-pushed
the
docker-postgres
branch
from
f9a75d3
to
ad3bfee
Compare
mykolasolodukha
requested changes
Nov 4, 2023
docker-compose.yml
Outdated
| bot: | ||
| hostname: bot | ||
| image: flea | ||
| environment: | ||
| - REDIS_URL=redis | ||
| - DATABASE_URL=postgres://postgres:123456@db:5432/postgres |
There was a problem hiding this comment.
Is it safe to run a postgres instance with such open credentials, given that we expose the 5432 port to external connections (line 16)?
There was a problem hiding this comment.
You are right, its better to hide it, but I was waiting for postgres code to be merged. I will hide it here and also variables for db container as well
There was a problem hiding this comment.
@mykolasolodukha fixed
|
@hexponent hey, if you could solve the conflicts and do the safety measure -- would be awesome! Will merge. Postgres is now activated within the bot |
hexponent
force-pushed
the
docker-postgres
branch
from
ad3bfee
to
a3e3ad3
Compare
|
Thank you! @hexponent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.