feature: Language analysis #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BloodyOcean
commented
Oct 28, 2023
BloodyOcean
commented
- Add language analysis via matplotlib chart
- Add language analysis via matplotlib chart
|
Awesome, I will merge it when our Postgres is ready for setup, thanks a lot ! |
Comment on lines
+13
to
+27
| users_lst = list(flatten_tortoise_model(el) for el in User.all()) | ||
|
|
||
| lang_counts = {} | ||
| for user in users_lst: | ||
| lang = user.language_code | ||
| if lang in lang_counts: | ||
| lang[lang] += 1 | ||
| else: | ||
| lang[lang] = 1 | ||
|
|
||
| # Sort the data by score | ||
| sorted_scores = sorted(lang_counts.items()) | ||
|
|
||
| # Extract the scores and counts for the chart | ||
| scores, counts = zip(*sorted_scores) |
There was a problem hiding this comment.
You can use GROUP BY equivalent in tortoise-orm to basically get a dict[str, int] with all the languages and the COUNT(*) of users who are using them.
From the top of my mind, the actual query would look like this:
language_counts: dict[str, int] = await User.all().group_by("language").values()I would suggest looking into it and maybe refactoring. Although the minimal version is clearly here already.
There was a problem hiding this comment.
Totally agree, that will be a good improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.