Add support for FMOD local parameters #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salzian
reviewed
Sep 24, 2023
Comment on lines
+4
to
+5
| //! Note that because `ignore_seek_speed` is `false` in these examples, | ||
| //! it could take a few seconds before you can hear the changes in these sound effects. |
There was a problem hiding this comment.
To avoid confusion, I would add one more line linking to https://www.fmod.com/docs/2.00/studio/parameters-reference.html
Salzian
previously approved these changes
Sep 24, 2023
examples/parameters.rs
Outdated
| //! FMOD local parameter example usage: | ||
| //! Press H and L to change the amount of traffic you can hear. | ||
| //! This example demonstrates FMOD parameter usage. | ||
| //! See https://www.fmod.com/docs/2.02/studio/parameters-reference.html for more details. |
There was a problem hiding this comment.
I intended this link to be at the bottom to clarify ignore_seek_speed.
Salzian
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for FMOD local parameters, including example usage. Closes #12.
This is just an initial approach. I'd suggest we consider parameter bindings in a future PR.