Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live update #38

Merged
merged 6 commits into from
Sep 24, 2023
Merged

Live update #38

merged 6 commits into from
Sep 24, 2023

Conversation

Salzian
Copy link
Owner

@Salzian Salzian commented Sep 24, 2023

This PR introduces the Live Update feature of FMOD studio. It's a simple flag, but I want to only include it to developers if they use a special flag. So they don't accidentally enable it in release builds.

@Salzian Salzian added the enhancement New feature or request label Sep 24, 2023
@Salzian Salzian self-assigned this Sep 24, 2023
@Salzian Salzian linked an issue Sep 24, 2023 that may be closed by this pull request
Copy link
Collaborator

@GitGhillie GitGhillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but I'm getting some warnings when not using the feature:

PS C:\Rust\bevy_fmod> cargo run --example minimal
warning: unused import: `FMOD_STUDIO_INIT_LIVEUPDATE`
 --> src\fmod_studio.rs:8:31
  |
8 |     FMOD_INIT_3D_RIGHTHANDED, FMOD_STUDIO_INIT_LIVEUPDATE, FMOD_STUDIO_INIT_NORMAL,
  |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: variable does not need to be mutable
  --> src\fmod_studio.rs:56:13
   |
56 |         let mut studio_flags = FMOD_STUDIO_INIT_NORMAL;
   |             ----^^^^^^^^^^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default

Can you please fix these?

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@GitGhillie GitGhillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@Salzian Salzian merged commit 9931923 into main Sep 24, 2023
@Salzian Salzian deleted the live-update branch September 24, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FMOD Live Update
2 participants