Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix velocity & doppler effect #39

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Fix velocity & doppler effect #39

merged 1 commit into from
Sep 24, 2023

Conversation

Salzian
Copy link
Owner

@Salzian Salzian commented Sep 24, 2023

Fixes #28
Fixes #29

Tested on spatial example.

@Salzian Salzian added the bug Something isn't working label Sep 24, 2023
@Salzian Salzian self-assigned this Sep 24, 2023
GitGhillie
GitGhillie approved these changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@GitGhillie GitGhillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this fixes the unstable doppler effect but I'm glad it works :)

@Salzian
Copy link
Owner Author

Salzian commented Sep 24, 2023

@GitGhillie because previously we ran the FMOD update on Update and the Velocity update on FixedUpdate. I guess it's only important they are aligned, so I moved them both to update.

@Salzian Salzian merged commit 8af8e8f into main Sep 24, 2023
@Salzian Salzian deleted the velocity-fix branch September 24, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGhillie GitGhillie GitGhillie approved these changes

Assignees

@Salzian Salzian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable doppler effect Velocity off by a factor 1000
2 participants
@Salzian @GitGhillie