Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better specification of versions in Cargo.toml #55

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Better specification of versions in Cargo.toml #55

merged 3 commits into from
Oct 21, 2023

Conversation

Salzian
Copy link
Owner

@Salzian Salzian commented Oct 1, 2023

Stumbled over this and thought some dependency notations could be improved.

@Salzian Salzian added the dependencies Pull requests that update a dependency file label Oct 1, 2023
@Salzian Salzian self-assigned this Oct 1, 2023
GitGhillie
GitGhillie previously approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@GitGhillie GitGhillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to remove the patch version from the other dependencies as well? Or the tilde requirement?

The current changes I agree with though.

@Salzian Salzian merged commit 51f7f91 into main Oct 21, 2023
@Salzian Salzian deleted the better-versions branch October 21, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGhillie GitGhillie GitGhillie approved these changes

Assignees

@Salzian Salzian

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Salzian @GitGhillie