Provide bundles for spatial audio #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2023
Merged
Salzian
reviewed
Oct 21, 2023
There was a problem hiding this comment.
Maybe separate the structs into separate files and introduce a bundle module?
There was a problem hiding this comment.
Added a bundle module but I'm pretty much indifferent to this, feel free to revert the commit if you change your mind
|
Still not a fan of bundles, but they are idiomatic and help first time users. |
Salzian
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition/alternative to #53.
Slightly simplifies spatial example, makes it more difficult to accidentally forget the Velocity component.
But it's still possible to add the components as we did previously, without the Velocity if the user prefers that. But #53 would need to be solved first.