Migrate to bevy 0.11 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salzian
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Changes look straight forward to me 👍 I like that they simplified the system scheduling.
Could you run rustfmt one more time? There are some minor format issues. I would do it myself, but I didn't get your perms to push to your branch. See this GitHub documentation page for more info on that topic.
README.md
Outdated
Comment on lines
51
to
52
| Version 0.0.1 would be the first usable MVP somewhat recommended for use. | ||
| Version 1.0.0 would be a hypothetical stable release. But that's still a long way to go. |
There was a problem hiding this comment.
Not true in the sense I initially intended to version this package, but could you just remove these two lines? Looking at it now, this "system" doesn't make much sense. There should only be 0.x and >=1.x. thx
Salzian
approved these changes
Jul 18, 2023
Salzian
pushed a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR ever :)
Notes: