Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't rely on CARGO environment variables at runtime #68

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

passivedragon
Copy link

Seems to me like any attempt at building a release build, i.e. anything cargo independent, necessarily fails due to unwrapping an environment variable that probably isn't set.

@passivedragon
Copy link
Author

passivedragon commented Jan 18, 2024

There still exist a couple other issues as it comes to pathing, I don't think the current approach with canonicalize is working as intended.

For predictability purposes I'd suggest using the binary path as a basis for resolving relative links, probably better than forcing the current working directory, that would limit dependent projects quite a bit. If that kind of behavior is wanted, users of the library can always amend the paths passed to bevy_fmod that way.

@Salzian Salzian assigned Salzian and unassigned Salzian Jan 18, 2024
@Salzian Salzian added the bug Something isn't working label Jan 18, 2024
@passivedragon
Copy link
Author

Any thoughts on this? I'd be ready to clean this up, if the general idea seems fine.

@Salzian
Copy link
Owner

Salzian commented Jan 31, 2024

Hey, I'm currently not actively developing this library. I'll try to take a look at this next weekend.

src/fmod_studio.rs Outdated Show resolved Hide resolved
src/fmod_studio.rs Outdated Show resolved Hide resolved
@Salzian
Copy link
Owner

Salzian commented Mar 20, 2024

Hey, we made some changes to the way we load banks and plugins. Can you check if your PR is still relevant? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants