Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Bevy 0.13 #70

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Update to Bevy 0.13 #70

merged 6 commits into from
Mar 4, 2024

Conversation

GitGhillie
Copy link
Collaborator

@GitGhillie GitGhillie commented Feb 12, 2024 •
edited
Loading

The relevant Bevy PR #'s are as following, although they only affect the examples.

Buttons: 10702, 10859, and potentially 11692.
Shapes: 11688.
Lights: 11347, and potentially 11581.

Seems like a trivial migration but sadly ran into the following error (using Windows) after making the changes:

LINK : fatal error LNK1181: cannot open input file 'fmod_vc.lib'

Afaik I haven't touched my setup since the 0.12 update. Only made the changes listed in this PR and I did cargo update and rustup update. Figured I'd still post here in case anyone else is interested.

Todo:

  • Use 0.13 in cargo.toml
  • Update Readme
  • Check if the light in the spatial example needs adjusting

@GitGhillie
Copy link
Collaborator Author

Seems to work on Linux. I'll continue investigating another day but if someone else on Windows can check that would be great!

@GitGhillie
Copy link
Collaborator Author

Not sure what changed exactly but it seems like it's not necessary anymore to rename the library files on Windows. I've updated the readme to reflect that.

@GitGhillie GitGhillie marked this pull request as ready for review March 3, 2024 20:10
@GitGhillie GitGhillie requested a review from Salzian March 3, 2024 20:10
@Salzian
Copy link
Owner

Salzian commented Mar 3, 2024

Afaik I haven't touched my setup since the 0.12 update. Only made the changes listed in this PR and I did cargo update and rustup update. Figured I'd still post here in case anyone else is interested.

Can confirm this is happening for me aswell. Maybe something changed in the Rust linker?

@Salzian
Update audio control and parameter adjustment functions
b3fa9cd 
The key inputs in the audio control and parameter adjustment functions have been updated. They've been changed to use ButtonInput instead of Input, and the specific KeyCode names have been adjusted to the recently updated KeyCode identifications.
Salzian
Salzian reviewed Mar 3, 2024
View reviewed changes
Copy link
Owner

@Salzian Salzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some input related stuff was missing in the example code.

Can you verify that the parameters example works for you? Something is wrong with my local setup I guess.

@GitGhillie
Copy link
Collaborator Author

Some input related stuff was missing in the example code.

Oops, thanks for fixing.

Can you verify that the parameters example works for you? Something is wrong with my local setup I guess.

The parameters example was missed when the paths were improved earlier, fixed.

Can confirm this is happening for me aswell. Maybe something changed in the Rust linker?

Thanks for confirming. I tried to find something to confirm this but I guess I don't know the right search terms. Anyways I think it's safe to assume that this is now the way to go.

@GitGhillie GitGhillie merged commit 686b50e into main Mar 4, 2024
@GitGhillie GitGhillie deleted the update-0.13 branch March 4, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salzian Salzian Salzian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitGhillie @Salzian