Impl Deref for newtypes #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The key inputs in the audio control and parameter adjustment functions have been updated. They've been changed to use ButtonInput instead of Input, and the specific KeyCode names have been adjusted to the recently updated KeyCode identifications.
GitGhillie
commented
Mar 4, 2024
Comment on lines
75
to
77
| fn stop(&self) { | ||
| self.event_instance.stop(StopMode::AllowFadeout).unwrap(); | ||
| self.0.stop(StopMode::AllowFadeout).unwrap(); | ||
| } |
There was a problem hiding this comment.
Here is an example of what I was talking about in the PR description
|
Can you elaborate what your initial goal was with this PR? |
Mainly to reduce the amount of code the user needs to write. This is easiest to see in the diff of the parameters example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to get opinions on this:
On
FmodStudioit's a clear improvement in my eyes.But on
AudioSourceit gets a bit hairy (internally, user-facing looks ok) becauseAudioSinkPlaybackcontains some function members with the same name as the ones inEventInstance. So you still need the.0syntax in some places (internally).