-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt the latest implementation for String#blank? from ActiveSupport and update benchmark result #33
base: master
Are you sure you want to change the base?
Conversation
10a95f5
to
f483e82
Compare
I noticed same thing and was going to do similar PR. I see about a ~1x to ~3x diff locally in benchmark. Still noticeable, but smaller than the ~10+ year old versions of ruby/rails this first worked on. Also noticed the ruby versions listed in the README are pretty out of date ... might be worth a once over on the ruby/rails versions supported to assist anyone arriving here with an "is this still relevant, given perf improvements in ruby/rails?" sort of question. |
Hi there! Is this still relevant, given perf improvements in ruby/rails? 😝 (I'm running Rails 7.2 and Ruby 3.3.4) Thank you! |
I added a copy of the latest Rails 8
Suggests there's still a ~1-3X benefit depending on string length. |
Diffs
I noticed a minor diffs between the latest code in ActiveSupport and benchmarking code in this gem.
After updating, the performance difference appears to be smaller; still this gem remains faster.
Thanks for making this gem. I really like this gem.