Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No check for empty file upload in common/src/file-upload.controller.ts #156

Open
gnaaruag opened this issue Jul 6, 2024 · 0 comments
Open

No check for empty file upload in common/src/file-upload.controller.ts #156

gnaaruag opened this issue Jul 6, 2024 · 0 comments
Assignees
@gnaaruag
Labels
enhancement New feature or request

Comments

@gnaaruag
Copy link
Contributor

gnaaruag commented Jul 6, 2024

Currently in common/src/file-upload.controller.ts empty file uploads are allowed to be uploaded. Proposed PR adds a check before letting the upload take place.

This ticket helps with the following aspect

  • Potential resource efficiency
  • potential security gains (to prevent a mass empty file upload exploit)
  • Only valid files pass through (improves data integrity)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnaaruag gnaaruag

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@techsavvyash @gnaaruag