Check empty file uploads, tests for the same and tests for local uploads on file interceptor

[gnaaruag]

Checklist

Make sure you have

• Added relevant @nestjs/swagger decorators wherever required
• Added test cases (unit and integration) wherever required

Description

Tests in #50

This PR adds tests for local uploads described in #50 to file-upload.interceptor.spec.ts
also adds e2e tests in the file upload sample app in sample/04-file-upload/test/app.e2e-spec.ts

fix for issue #156

• this adds a empty file upload check to the file-upload.controller.ts in packages/common/src
• also adds tests for correct file upload, empty file upload
• if the file is found to be empty a status code of 400 is sent, else it is uploaded further according to process.env.STORAGE_MODE
• in file-upload.interceptor the line request.raw = request.raw || request; allows for valid request body to pass through

Steps to test #50

Navigate to packages/common/test and run npm run test interceptor/file-upload.interceptor.spec.ts
Navigate to sample/04-file-upload and run npm run test:e2e

Steps to test #156

to test manually
create a post request to /file/upload-file
test with empty file and non empty file via multipart/form-data

to run automated test
navigate to samples/04-file-upload and run npm run test:e2e

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[techsavvyash]

is this expected.

[gnaaruag]

seems to have been a mix up, will fix it asap

[techsavvyash]

Merging this thanks for the effort @gnaaruag

[VedantKhairnar]

Hello @techsavvyash
Will you pls close the corresponding issues as well if the required PR is merged?
Thanks.

[VedantKhairnar]

Hey there,
Thanks for your contribution.
As part of Augtoberfest, we want to reward you for your contributions, so pls fill out this form by 19th Sept.
Thanks.