Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interview group forms #1573

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add interview group forms #1573

wants to merge 12 commits into from

Conversation

magsyg
Copy link
Contributor

@magsyg magsyg commented Oct 29, 2024

first draft

Snorre98
Snorre98 reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta en egen review først. Så noen ting som tyder på at det ikke er helt ferdigstilt.

backend/samfundet/urls.py Outdated Show resolved Hide resolved
@robines robines marked this pull request as draft October 29, 2024 22:51
@magsyg magsyg marked this pull request as ready for review November 5, 2024 18:59
Snorre98
Snorre98 reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se kommentarer. Syns generel "naming" av koseptet burde endres. Tror det gir mer mening å gp ut i fra at det er en gruppe med stillinger som har ett delt inverju. Dermed blir det noe sånn som PositionsSharedInterview. Har kommentert i views.py, men det vil også kreve at man endrer på "naming" andre plasser hvor det refereres til shared interview.

backend/samfundet/views.py Outdated
@@ -633,6 +633,13 @@ class RecruitmentForRecruiterView(ModelViewSet):
queryset = Recruitment.objects.all()


@method_decorator(ensure_csrf_cookie, 'dispatch')
class RecruitmentSharedInterviewGroupView(ModelViewSet):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kunne man kalt dette noe annet? Er det ikke snakk om en "gruppe" med stillinger som har delt intervju, så kanskje: RecruitmentSharedInterviewPositionsView

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

og da det samme med modellen RecruitmentPositionsSharedInterviewGroup blir RecruitmentSharedInterviewPositions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

backend/samfundet/views.py
@method_decorator(ensure_csrf_cookie, 'dispatch')
class RecruitmentSharedInterviewGroupView(ModelViewSet):
permission_classes = (DjangoModelPermissionsOrAnonReadOnly,)
serializer_class = RecruitmentPositionSharedInterviewGroupSerializer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RecruitmentSharedInterviewPositionsSerializer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

backend/samfundet/views.py Outdated
@@ -1111,7 +1118,7 @@ def get_queryset(self) -> Response:
return Recruitment.objects.filter(visible_from__lte=timezone.now(), actual_application_deadline__gte=timezone.now())


class RecruitmentInterviewGroupView(APIView):
class RecruitmentInterviewGroupRecruitmentView(APIView):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RecruitmentSharedInterviewPositionsRecruitmentView

??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

frontend/src/PagesAdmin/RecruitmentGangOverviewPage/RecruitmentGangOverviewPage.tsx
value: (
<>
<RecruitmentInterviewGroupsList />
<Button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knappen burde være over listen. Den blir litt gjemt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...upsList/components/RecruitmentInterviewGroupComponent/RecruitmentInterviewGroupComponent.tsx Outdated
@@ -22,6 +28,19 @@ export function RecruitmentInterviewGroupComponent({ interviewGroup }: Recruitme
return { cells: [dbT(position, 'name'), dbT(position.gang, 'name')] };
})}
/>
<div className={styles.footer}>
<Button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fåre "something wrong" error når jeg trykker på denne. Har seeda

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funker for meg, noe galt med din side

...PagesAdmin/RecruitmentInterviewGroupFormAdminPage/RecruitmentInterviewGroupFormAdminPage.tsx Outdated
import { AdminPageLayout } from '../AdminPageLayout/AdminPageLayout';
import { RecruitmentInterviewGroupForm } from './RecruitmentInterviewGroupForm';

export function RecruitmentInterviewGroupFormAdminPage() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mangler komplett breadcrumb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...PagesAdmin/RecruitmentInterviewGroupFormAdminPage/RecruitmentInterviewGroupFormAdminPage.tsx Outdated
positions: sharedInterview?.positions?.map((pos) => pos.id) || [],
};

const title = sharedInterviewGroupId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg føler det gir mer mening for brukeren titelen er "Opprett stillingsgruppe for felles intervju" eller lignende.

frontend/src/i18n/translations.ts
@@ -267,7 +267,7 @@ export const nb = prepareTranslations({
[KEY.recruitment_no_interviews]: 'Ingen intervjuer',
[KEY.recruitment_interview_set]: 'Sett intervju',
[KEY.recruitment_interview_groups]: 'Intervjugrupper',
[KEY.recruitment_interview_group]: 'Intervjugrupper',
[KEY.recruitment_interview_group]: 'Intervjugruppe',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hva med "Opprett stillingsgruppe for felles intervju"?

Snorre98
Snorre98 reviewed Nov 7, 2024
View reviewed changes
...tend/src/PagesAdmin/RecruitmentInterviewGroupFormAdminPage/RecruitmentInterviewGroupForm.tsx Outdated
name="positions"
render={({ field }) => (
<FormItem className={styles.item}>
<FormLabel>{`${t(KEY.common_name)} ${t(KEY.common_english)}`}</FormLabel>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Label burde være noe annet. F.eks. "Søk på stillingstittel"/""Search position title"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Snorre98
Snorre98 reviewed Nov 7, 2024
View reviewed changes
...tend/src/PagesAdmin/RecruitmentInterviewGroupFormAdminPage/RecruitmentInterviewGroupForm.tsx Outdated
)}
/>
</div>
<Button type="submit" rounded={true} theme="green">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikke mulig å submite. Får toast error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snorre98 Snorre98 Snorre98 left review comments

@Mathias-a Mathias-a Awaiting requested review from Mathias-a Mathias-a is a code owner

@robines robines Awaiting requested review from robines robines is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@magsyg magsyg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magsyg @robines @Snorre98