Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show osc when file loaded if osc_on_seek=yes #107

Closed
Keith94 opened this issue Oct 26, 2024 · 0 comments · Fixed by #111
Closed

Don't show osc when file loaded if osc_on_seek=yes #107

Keith94 opened this issue Oct 26, 2024 · 0 comments · Fixed by #111
Labels
bug Something isn't working

Comments

@Keith94
Copy link
Contributor

Keith94 commented Oct 26, 2024 •
edited
Loading

Seems like possible bug where osc thinks you're seeking even though you didn't seek.

When osc_on_seek=yes, osc shows up immediately when you load up a file or change playlist entry

When osc_on_seek=no, osc does not show up when file loaded

Note: Previous forks had this behavior separated with a user option
@Samillion Samillion linked a pull request Oct 26, 2024 that will close this issue
refactor: don't show osc on start when osc_on_seek=yes #111
Merged
@Samillion Samillion added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: don't show osc on start when osc_on_seek=yes Samillion/ModernZ
2 participants
@Keith94 @Samillion